Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: Service name must be less than 15 chars #1479

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

xogoodnow
Copy link
Contributor

The service name can not be more than 15 characters.

RelatedIssue

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Looks great, thanks for fixing this @xogoodnow!

@xogoodnow
Copy link
Contributor Author

LGTM! Looks great, thanks for fixing this @xogoodnow!
Thank you

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.93%. Comparing base (1192264) to head (bc5fb19).
Report is 8 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (1192264) and HEAD (bc5fb19). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (1192264) HEAD (bc5fb19)
unittests 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1479      +/-   ##
==========================================
- Coverage   81.45%   72.93%   -8.53%     
==========================================
  Files         149      148       -1     
  Lines       15253    15244       -9     
==========================================
- Hits        12425    11118    -1307     
- Misses       2228     3397    +1169     
- Partials      600      729     +129     
Flag Coverage Δ
integration-test 59.79% <ø> (+0.01%) ⬆️
k8s-integration-test 60.60% <ø> (+0.72%) ⬆️
oats-test 34.02% <ø> (ø)
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grcevski grcevski merged commit 8fb7d9d into grafana:main Jan 6, 2025
13 checks passed
@grcevski
Copy link
Contributor

grcevski commented Jan 6, 2025

Thanks again @xogoodnow for your first contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants